Fix return type of request_prov_data for dbus-next#165
Open
ntrrgc wants to merge 1 commit intoSilvairGit:masterfrom
Open
Fix return type of request_prov_data for dbus-next#165ntrrgc wants to merge 1 commit intoSilvairGit:masterfrom
ntrrgc wants to merge 1 commit intoSilvairGit:masterfrom
Conversation
dbus-next methods are supposed to return lists, not tuples. I'd rather dbus-next allowed that... but that's beside the point. This patch fixes request_prov_data() in interfaces.py to add a missing conversion so that a type error is not thrown on return when marshalling the return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbus-next methods are supposed to return lists, not tuples. I'd rather dbus-next allowed that... but that's beside the point.
This patch fixes request_prov_data() in interfaces.py to add a missing conversion so that a type error is not thrown on return when marshalling the return type.